-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration module with quarkus-websockets-next #487
Conversation
f0bebfd
to
300748d
Compare
This module allows for automatic use of memoryId when no object is specified
Are you also going to update the samples that use websockets? |
I will after this, yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tried migrating my own project to it and it worked.
Hm, one inconvenience that I now noticed is that by making the AI service session-scoped, I can no longer call it from a REST endpoint. I don't quite understand why we need to make it session-scoped? Isn't the service in itself stateless and only controlled by what the memory contains? |
By making it
It is, but it integrates with memory and can thus be used for automatic memory management.
I suggest using different AI services. |
This module allows for automatic use of memoryId when no object is specified
TODO: add tests, fix for native image and add documentation