Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration module with quarkus-websockets-next #487

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Apr 23, 2024

This module allows for automatic use of memoryId when no object is specified

TODO: add tests, fix for native image and add documentation

@geoand geoand force-pushed the websockets branch 2 times, most recently from f0bebfd to 300748d Compare April 24, 2024 07:55
@geoand geoand marked this pull request as ready for review April 24, 2024 07:57
@geoand geoand requested a review from a team as a code owner April 24, 2024 07:57
This module allows for automatic use of memoryId when no
object is specified
@jmartisk
Copy link
Collaborator

Are you also going to update the samples that use websockets?

@geoand
Copy link
Collaborator Author

geoand commented Apr 24, 2024

I will after this, yes

Copy link
Collaborator

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried migrating my own project to it and it worked.

@geoand geoand merged commit 8c4429e into main Apr 24, 2024
12 checks passed
@geoand geoand deleted the websockets branch April 24, 2024 10:02
@jmartisk
Copy link
Collaborator

Hm, one inconvenience that I now noticed is that by making the AI service session-scoped, I can no longer call it from a REST endpoint. I don't quite understand why we need to make it session-scoped? Isn't the service in itself stateless and only controlled by what the memory contains?

@geoand
Copy link
Collaborator Author

geoand commented Apr 24, 2024

I don't quite understand why we need to make it session-scoped?

By making it @SessionsScoped we are able to automatically remove all memory when the websocket session closes.

Isn't the service in itself stateless and only controlled by what the memory contains?

It is, but it integrates with memory and can thus be used for automatic memory management.

I can no longer call it from a REST endpoint

I suggest using different AI services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants