Fix duplicate method exception when registering ai services #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iocanel
force-pushed
the
fix-duplicate-method-exception
branch
from
589c8fc
to
dc99610
Compare
geoand
reviewed
Apr 24, 2024
|
|
||
| import org.jboss.jandex.MethodInfo; | ||
|
|
||
| public final class MethodUtil { |
There was a problem hiding this comment.
I am wondering if there is already a util like this in Quarkus
There was a problem hiding this comment.
Maybe Methods has something like it. Looking.
There was a problem hiding this comment.
I'll get back to you in a few minutes
There was a problem hiding this comment.
Ok, meanwhile I added a couple of tests:
- one the verifies the problem
- one the verifies the correctness of the util
There was a problem hiding this comment.
I'll get back to you in a few minutes
Does io.quarkus.gizmo.SignatureBuilder do the trick?
There was a problem hiding this comment.
No, I don't think we can use that.
They don't seem to provide the name and that makes it of limited use to our use case: https://github.com/quarkusio/gizmo/blob/main/src/main/java/io/quarkus/gizmo/MethodSignatureBuilderImpl.java
iocanel
force-pushed
the
fix-duplicate-method-exception
branch
from
dc99610
to
fc8b469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #491