Improve user experience for samples #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
geoand
commented
Apr 24, 2024
geoand
commented
- Convert samples to standalone applications
- Vastly improve the chatbot samples
This is done to allow users to copy and paste them without worrying about bringing in a ton of Maven configuration
These samples use the WebSockets Next integration which streamlines both the websockets part and the memory management part Closes: #432
geoand
requested review from
jmartisk and
cescoffier
and removed request for
a team
|
Awesome. I was working on exact same standaloness. +100 |
maxandersen
reviewed
Apr 24, 2024
| <maven.compiler.release>17</maven.compiler.release> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id> |
There was a problem hiding this comment.
Any reason to not have it use the platform as is recommended for user apps?
There was a problem hiding this comment.
The only reason is that I can easily switch to snapshot Quarkus when needed 😎
There was a problem hiding this comment.
+1, I tackle this problem often, having to also build a snapshot of the platform would be painful
There was a problem hiding this comment.
In Quarkus quick start it's a property so easy to override. Snapshot/Quarkus can be in a profile.
Just that it would be nice the samples works as defacto standard Quarkus app and allow quarkus ext add work like every other default app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.