Add minimal html UI for email me a peom #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be some bug in the UI as I can't see to type anything into it |
Let me check! |
You are not supposed to type anything. It's where the poem is displayed when you click the send me a poem button. |
|
Which seems to be an indication that this is confusing. |
|
Ok yeah, in that case it is pretty confusing 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #563
So, the pull request adds a minimal index.html that provides a UI for Email me a poem.
It also catches errors and hints users.
Note, the UI is as minimal as it gets (no vaadin components here) for minimalism shake. If we prefer to have a consistent UI all across our samples, I am all for aligning.
edit: The PR also improves the prompt, so that the poem is actually displayed in the response.