Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vaadin progress bar in dev-ui embedding store #575

Merged
merged 2 commits into from
May 13, 2024
Merged

Use vaadin progress bar in dev-ui embedding store #575

merged 2 commits into from
May 13, 2024

Conversation

iocanel
Copy link
Collaborator

@iocanel iocanel commented May 13, 2024 •
edited by geoand
Loading

@iocanel iocanel requested a review from a team as a code owner May 13, 2024 12:19
@geoand geoand requested a review from jmartisk May 13, 2024 12:26
@jmartisk
Copy link
Collaborator

Nice! Could you please, while we're at this, move the ${this._addEmbeddingConfirmation} element under the Create and store button? For searching, the progress bar shows under the search form+button, but for adding, its progress bar shows above the form, which looks weird.

cescoffier
cescoffier approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iocanel getting full-stack! Wow! :-)

@jmartisk jmartisk merged commit d6ba37a into quarkiverse:main May 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@jmartisk jmartisk jmartisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use progress bars on other pages beyond Chat
3 participants
@iocanel @jmartisk @cescoffier