Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make token limit configuration for Ollama optional #589

Merged
merged 2 commits into from
May 16, 2024
Merged

Make token limit configuration for Ollama optional #589

merged 2 commits into from
May 16, 2024

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented May 15, 2024

This way Ollama can decide what the default should be (if any)

@geoand geoand requested a review from a team as a code owner May 15, 2024 12:58
@iocanel iocanel self-requested a review May 15, 2024 19:12
iocanel
iocanel approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verify that it does solve the issue I was experiencing.
Code also looks good to me.

@geoand
Copy link
Collaborator Author

geoand commented May 16, 2024

Thanks!

@geoand geoand merged commit 369ac9b into main May 16, 2024
11 of 12 checks passed
@geoand geoand deleted the ollama-token-opt branch May 16, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geoand @iocanel