Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly configure for embedding model #597

Merged
merged 1 commit into from
May 17, 2024
Merged

Properly configure for embedding model #597

merged 1 commit into from
May 17, 2024

Conversation

csotiriou
Copy link
Contributor

@csotiriou csotiriou commented May 17, 2024 •
edited
Loading

Fixes wrong configuration being passed while initializing Azure Embeddings client.

@csotiriou csotiriou requested a review from a team as a code owner May 17, 2024 07:45
@geoand geoand changed the title fixed azureADToken not being passed from configuration while innitializing embeddings Properly configure for embedding model May 17, 2024
geoand
geoand approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit ac61b94 into quarkiverse:main May 17, 2024
12 checks passed
@csotiriou csotiriou deleted the bugfix/azure-embeddings-configuration branch May 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csotiriou @geoand