Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vertexai.gemini timeout configurable #640

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

exaV
Copy link
Contributor

@exaV exaV commented May 30, 2024

and inherit the default from quarkus.langchain4j.timeout

@exaV exaV requested a review from a team as a code owner May 30, 2024 16:16
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand
Copy link
Collaborator

geoand commented May 31, 2024

The code needs to be formatted properly, see:

Error:  Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.23.0:validate (default) on project quarkus-langchain4j-vertex-ai-gemini: File '/home/runner/work/quarkus-langchain4j/quarkus-langchain4j/model-providers/vertex-ai-gemini/runtime/src/main/java/io/quarkiverse/langchain4j/vertexai/runtime/gemini/VertexAiGeminiRecorder.java' has not been previously formatted. Please format file (for example by invoking `mvn -f model-providers/vertex-ai-gemini/runtime net.revelc.code.formatter:formatter-maven-plugin:2.23.0:format`) and commit before running validation! -> [Help 1]

and inherit the default from quarkus.langchain4j.timeout
@exaV
Copy link
Contributor Author

exaV commented May 31, 2024

Thanks for providing the Error along with the command, I did not notice what was wrong. Should be good now.

@geoand geoand merged commit 3ea90a0 into quarkiverse:main Jun 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vertexai.gemini does not respect timeout
2 participants