Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release workflow #403

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Update release workflow #403

merged 2 commits into from
Jan 26, 2024

Conversation

gastaldi
Copy link
Member

zhfeng
zhfeng reviewed Jan 26, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml
java-version: 11
cache: 'maven'
server-id: ossrh
server-username: MAVEN_USERNAME
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it coming from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the environment properties set in the generated settings.xml during the release. They are set in https://github.com/quarkiverse/quarkus-mybatis/pull/403/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R62

.github/workflows/release.yml
cache: 'maven'
server-id: ossrh
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

.github/workflows/release.yml
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
gpg-passphrase: MAVEN_GPG_PASSPHRASE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@zhfeng zhfeng merged commit a45a564 into master Jan 26, 2024
1 check passed
@zhfeng zhfeng deleted the update_release branch January 26, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhfeng zhfeng zhfeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gastaldi @zhfeng