Update default Neo4j image version for DevServices #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-simons I see you've just released 3.10.0, how unfortunate timing 🤣 |
|
Haha, yes indeed. But fwiw, you are pretty right to open up the PR, fun fact: I was just thinking about that yesterday. |
michael-simons
requested changes
May 7, 2024
deployment/src/main/java/io/quarkus/neo4j/deployment/DevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
jmartisk
force-pushed
the
devservices-image-version
branch
from
e466bd5
to
8f8f0b3
Compare
michael-simons
approved these changes
May 7, 2024
|
@all-contributors please add @jmartisk for code |
|
I've put up a pull request to add @jmartisk! 🎉 |
|
Thanks, Jan! |
|
Thanks to you too @michael-simons. Any chance you'll plan to make another release with this soon? I'd like to avoid adding temporary hacks to the langchain4j extension, so the integration will have to wait for a release here. |
|
No, I really don't mind… But I'm gonna put out then a new major, with no other changes, as 4.4 to 5 is a bit of a leap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to implement a Neo4j embedding store for the quarkus-langchain4j extension so I need vector search capabilities, which seem to be added in Neo4j 5.x. Therefore it would be nice to upgrade the default version, so we don't have to either add a hack in the
quarkus-langchain4jextension to override the default, or require end users to do it.