Add namespace in extension link #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
|
@melloware ^^^ |
|
Oh nice!! Thanks for fixing! |
|
@all-contributors add @phillip-kruger as a contributor for bugs |
|
I've put up a pull request to add @phillip-kruger! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #quarkusio/quarkus#32280
(As you know the new Dev UI is still in progress).
The namespace was added as an attribute to be able to automatically pick up the unique name for the extension.
We also now pass in the extension name (still in main branch, should be in CR2) so then you can remove the hardcoded NAME.