Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import org.eclipse.microprofile.rest.client.annotation.RegisterProvider when custom-register-providers is used #158

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Import org.eclipse.microprofile.rest.client.annotation.RegisterProvider when custom-register-providers is used #158

merged 3 commits into from
Oct 20, 2022

Conversation

YassinHajaj
Copy link
Contributor

There is a bug actually in the released 0.11.0.
I'll still need to write / correct a few tests for this.

@YassinHajaj YassinHajaj mentioned this pull request Oct 19, 2022
Closed
@ricardozanini
Copy link
Member

Thank you @YassinHajaj. Now your comment on the other issue makes more sense. Indeed is a case that we didn't anticipate.

@YassinHajaj
Copy link
Contributor Author

Hey @ricardozanini ,
You're welcome :) I think the PR is ready now.
By the way, do you have any idea when we can expect the 0.12.0 ?
If there's anything else I can help with, don't hesitate

@ricardozanini
Copy link
Member

By the way, do you have any idea when we can expect the 0.12.0 ?

I believe we can release it after this PR is merged. cc @hbelmiro wdyt?

@ricardozanini ricardozanini marked this pull request as ready for review October 20, 2022 12:29
@ricardozanini ricardozanini self-requested a review October 20, 2022 12:31
@hbelmiro
Copy link
Contributor

I believe we can release it after this PR is merged. cc @hbelmiro wdyt?

I agree @ricardozanini.

@ricardozanini ricardozanini mentioned this pull request Oct 20, 2022
Closed
@ricardozanini ricardozanini linked an issue Oct 20, 2022 that may be closed by this pull request
Issues with quarkus-openapi-generator and existing rest-client #157
Closed
@ricardozanini ricardozanini removed a link to an issue Oct 20, 2022
Issues with quarkus-openapi-generator and existing rest-client #157
Closed
@ricardozanini ricardozanini linked an issue Oct 20, 2022 that may be closed by this pull request
Import org.eclipse.microprofile.rest.client.annotation.RegisterProvider when custom-register-providers is used #159
Closed
hbelmiro
hbelmiro approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ricardozanini ricardozanini merged commit b207ec6 into quarkiverse:main Oct 20, 2022
@ricardozanini
Copy link
Member

@all-contributors please add @YassinHajaj for code

@allcontributors allcontributors bot mentioned this pull request Oct 20, 2022
Merged
@allcontributors
Copy link
Contributor

@ricardozanini

I've put up a pull request to add @YassinHajaj! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@melloware melloware melloware approved these changes

@hbelmiro hbelmiro hbelmiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import org.eclipse.microprofile.rest.client.annotation.RegisterProvider when custom-register-providers is used
4 participants
@YassinHajaj @ricardozanini @hbelmiro @melloware