New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control when path has not 'src' in it #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gwydionmv do you mind including a test for this use case?
|
@gwydionmv can't you just define a path without src with the property? quarkus.openapi-generator.codegen.input-base-dir=openapi-definitions |
@hbelmiro the property it is relative to the project base directory. E.g. if you have a project called The lack of src in the path is not related to the property, but to the sourceDir that's being set up automatically by maven and the quarkus compiler plugin. It's something similar to the issue we opened last week for the /test directory: it sets different paths depending on I don't know what yet. For your example tests, it adds the /test; for some of our projects, only /src/main; for others, it also includes /target/generated-sources... To sum up, it's not something we can configure via input-base-dir property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the contribution @gwydionmv.
@ricardozanini please check this out when you have a moment to spare :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll release a patch version to include this fix. Thank you, @gwydionmv
Co-authored-by: Gwydion Martin <gmartin@theworkshop.com>
Fixing issue #196
An exception was being thrown when trying to substring a path not including 'src' in it. Now it's controlled that the index for the substring is valid before doing it.