Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange docs #678

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Rearrange docs #678

merged 1 commit into from
Mar 5, 2024

Conversation

mcruzdev
Copy link
Collaborator

@mcruzdev mcruzdev commented Mar 4, 2024

Many thanks for submitting your Pull Request ❤️!

Fixes #672

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@mcruzdev mcruzdev marked this pull request as ready for review March 4, 2024 03:06
Copy link
Contributor

github-actions bot commented Mar 4, 2024

🎊 PR Preview 3400b95 has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-678.surge.sh

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mcruzdev!
I just left a few suggestions to fix the OpenAPI case, that probably already existed before this PR.

docs/modules/ROOT/pages/client.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/client.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/server.adoc Outdated Show resolved Hide resolved
@mcruzdev
Copy link
Collaborator Author

mcruzdev commented Mar 5, 2024

Great work @mcruzdev! I just left a few suggestions to fix the OpenAPI case, that probably already existed before this PR.

Thank you @hbelmiro, I will squash soon!

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcruzdev We squash when we merge.
Can I merge it?

@mcruzdev
Copy link
Collaborator Author

mcruzdev commented Mar 5, 2024

@mcruzdev We squash when we merge. Can I merge it?

Yes! Thank you for reviewing it!

@hbelmiro hbelmiro merged commit 6f2904b into quarkiverse:main Mar 5, 2024
11 checks passed
@mcruzdev mcruzdev deleted the issue-672 branch March 5, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearrange docs index page to clarify the extensions structure
4 participants