-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#693 - Allow YAML for Server Generation #701
Conversation
Hi @hbelmiro! I did not understand how the integration-tests were triggered, not this should be fixed... |
🎊 PR Preview 4cde6ca has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-701.surge.sh |
@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR. @ricardozanini is this approval really needed? We could be more agile by removing it. |
...io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioOpenApiServerCodegen.java
Dismissed
Show dismissed
Hide dismissed
This is needed for security reasons for first time contributors |
Yes, I agree it makes sense having them, we have them in Apicurio as well. |
@lizzyTheLizard can u rebase? |
@ricardozanini: Done |
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
I have added the possibility to use YAML Specifications for server side. As Apicurio only supports JSON, YAML-Files are converted to JSON on the fly. As the documentation for server-side was quite wrong, I changed it accordingly, even though there is already another PR #689 fixing #686 open that will be redundant now.
While handling this, I directly added the possibility to change the base folder. Up to now, all specs are taken from 'resources/openapi', now you can overwrite this with a property as hinted incorrectly by the docs. => This is not directly related to #693, but I thought that property document the current state. I hope it is fine that I added this to this PR directly.