Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#693 - Allow YAML for Server Generation #701

Merged
merged 5 commits into from
Apr 28, 2024

Conversation

lizzyTheLizard
Copy link
Contributor

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

I have added the possibility to use YAML Specifications for server side. As Apicurio only supports JSON, YAML-Files are converted to JSON on the fly. As the documentation for server-side was quite wrong, I changed it accordingly, even though there is already another PR #689 fixing #686 open that will be redundant now.

While handling this, I directly added the possibility to change the base folder. Up to now, all specs are taken from 'resources/openapi', now you can overwrite this with a property as hinted incorrectly by the docs. => This is not directly related to #693, but I thought that property document the current state. I hope it is fine that I added this to this PR directly.

@lizzyTheLizard lizzyTheLizard changed the title Issue 693 - Allow YAML and #693 - Allow YAML for Server Generation Apr 13, 2024
@lizzyTheLizard
Copy link
Contributor Author

Hi @hbelmiro! I did not understand how the integration-tests were triggered, not this should be fixed...

Copy link
Contributor

github-actions bot commented Apr 14, 2024

🎊 PR Preview 4cde6ca has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-701.surge.sh

@hbelmiro
Copy link
Contributor

@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR.

@ricardozanini is this approval really needed? We could be more agile by removing it.

@ricardozanini ricardozanini added the area:server This item is related to the server extension label Apr 15, 2024
@ricardozanini
Copy link
Member

@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR.

@ricardozanini is this approval really needed? We could be more agile by removing it.

This is needed for security reasons for first time contributors

@carlesarnal
Copy link
Contributor

@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR.
@ricardozanini is this approval really needed? We could be more agile by removing it.

This is needed for security reasons for first time contributors

Yes, I agree it makes sense having them, we have them in Apicurio as well.

@ricardozanini
Copy link
Member

@lizzyTheLizard can u rebase?

@lizzyTheLizard
Copy link
Contributor Author

@ricardozanini: Done

@hbelmiro hbelmiro merged commit e710dd6 into quarkiverse:main Apr 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:server This item is related to the server extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants