Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use chart appVersion in labels #822

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

csviri
Copy link
Contributor

@csviri csviri commented Feb 7, 2024

drops redundant Values.version

drops redundant Values.version

Signed-off-by: csviri <csviri@gmail.com>
@csviri csviri marked this pull request as ready for review February 7, 2024 15:04
@csviri csviri self-assigned this Feb 7, 2024
Copy link
Member

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me but I'll let @jcechace give the last word on it.

@csviri
Copy link
Contributor Author

csviri commented Feb 7, 2024

Will do also some additional testing before merge

@jcechace
Copy link
Contributor

jcechace commented Feb 8, 2024

LGTM, thank you for the quick fix! Very much appreciated.

@metacosm when do you see this getting into a release?

@jcechace
Copy link
Contributor

jcechace commented Feb 8, 2024

@csviri when you are at it. I think it's fine to sneak in one typo fix

https://github.com/quarkiverse/quarkus-operator-sdk/blob/main/core/deployment/src/main/resources/helm/static/README.md?plain=1#L5

should likely be either

- `watchNamespaces` - namespaces to be watched, it's either a list of namespaces, or one of special values:
  - `JOSDK_ALL_NAMESPACES` to watch all namespaces, or
  - `JOSDK_WATCH_CURRENT` to watch the current namespace

Note: Adds , or

Or straight up

- `watchNamespaces` - namespaces to be watched, it's  one of 
  -  List of namespaces
  - `JOSDK_ALL_NAMESPACES` to watch all namespaces, or
  - `JOSDK_WATCH_CURRENT` to watch the current namespace

It's a total nitpick but that sentence always hits me in the face when opening the readme :).

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm merged commit 30fff93 into main Feb 8, 2024
5 checks passed
@metacosm metacosm deleted the helm-version-fixes branch February 8, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart generation sets {{ .Values.version }} based on container tag rather than app version
3 participants