fix: remove duplicated and wrong env variable #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
metacosm
commented
Mar 20, 2024
metacosm
commented
- fix: properly log when helm generation is disabled
- fix: do not modify deployment as it is live and reused elsewhere
Signed-off-by: Chris Laprun <claprun@redhat.com>
Fixes #855 Signed-off-by: Chris Laprun <claprun@redhat.com>
|
@metacosm LGTM. I will attempt to build QOSDK from sources and try it against real source. If everything works, is there a chance for you to cut a release containing this fix later today / tomorrow? |
That's the plan. |
|
@metacosm Just tested the fix and all seems to be in order. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.