Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@RBACRoleRef to assign existing cluster roles #865

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

dloiacono
Copy link
Contributor

Added new annotation @RBACRoleRef to assign an existing cluster role to the controllers

@dloiacono dloiacono marked this pull request as ready for review April 17, 2024 07:55
Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added 2 remarks on API

Copy link
Contributor

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dloiacono and others added 3 commits April 23, 2024 13:52
…yment/AddRoleBindingsDecorator.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
…yment/AddRoleBindingsDecorator.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
@dloiacono dloiacono requested a review from metacosm April 23, 2024 20:06
domenico.loiaconoa and others added 2 commits April 24, 2024 14:27
@metacosm metacosm merged commit cae40e9 into quarkiverse:main Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants