Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Quarkus 3.4.0 - Replace VertxRecorder with VertxEventBusConsumerRecorder #168

Merged

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Sep 20, 2023

Fixes VertxRecorder removal in 3.4
In 3.5 we will use #167, benefiting from quarkusio/quarkus#35949
cc @kdubb @gsmet @geoand
Fixes #165

@vsevel
Copy link
Contributor Author

vsevel commented Sep 20, 2023

waiting for @vmargerin's test results
if ok, I will merge and release

@gsmet
Copy link
Member

gsmet commented Sep 20, 2023

Ideally, we would need a release by 1pm as the Platform is very broken.
When it is released, please ping me and I will include the update in the PR updating to 3.4.1 to only have one CI run for both.

@vsevel vsevel merged commit 3e61533 into quarkiverse:main Sep 20, 2023
1 check passed
@vsevel vsevel deleted the feature/VertxEventBusConsumerRecorder branch September 20, 2023 09:25
@vmargerin
Copy link

@vsevel
Our tests works with Quarkus 3.4.0, I also tested with this issue #78 (comment) and it works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension incompatible with Quarkus 3.4.0
4 participants