Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capstone version compatibility #37

Closed
patacca opened this issue Oct 28, 2023 · 2 comments
Closed

Capstone version compatibility #37

patacca opened this issue Oct 28, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.1.0

Comments

@patacca
Copy link
Collaborator

patacca commented Oct 28, 2023

After merging #36 we will break compatibility with older versions of capstone. We should identify which version is the first one that is compatible with qbindiff and enforce it in pyproject.toml
@patacca patacca added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 28, 2023
@patacca patacca added this to the 1.1.0 milestone Oct 28, 2023
@RobinDavid
Copy link
Contributor

I just checked. Its the very latest: 5.0.1.

Previous versions don't have wasm_const or the enum value arm64_const.ARM64_OP_SVCR which were apparently introduced in the latest.

@patacca
Copy link
Collaborator Author

patacca commented Nov 10, 2023

This has been now enforced.

@patacca patacca closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@RobinDavid @patacca