Update OperandType for new capstone version, split loader option in t… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he cli, add new option to directly set the capstone ARCH and MODE for the decompilation (used by binexport backend)
patacca
requested changes
Oct 28, 2023
There was a problem hiding this comment.
Thanks for the precious PR.
There are a few remarks:
- Since we now introduced the options to specify the architecture, the
--enable-cortexmoption doesn't make much sense anymore so you can also remove it. - Update the README to reflect the changes in the CLI
Adhere to the coding style by runningtox -e format
This was referenced Oct 28, 2023
|
I've corrected a couple of typos and removed some leftovers. For the rest it LGTM. |
patacca
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he cli, add new option to directly set the capstone ARCH and MODE for the decompilation (used by binexport backend)