Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Use a separate version for IDE config #345

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

fedinskiy
Copy link
Contributor

Quarkus IDE config is not productised, so it should always use upstream version
Also, update Quarkus version to 3.8.2
Partially reverts #311

@fedinskiy fedinskiy requested a review from rsvoboda March 11, 2024 09:05
@fedinskiy fedinskiy changed the title Use a separate version for IDE config [3.8] Use a separate version for IDE config Mar 11, 2024
@rsvoboda
Copy link
Member

Please check the failures and conflict in pom.xml

Quarkus IDE config is not productised, so it should always use upstream version
Also, update version to 3.8.2
See QUARKUS-4028 for details
@fedinskiy
Copy link
Contributor Author

Resolved the conflict.
Failures in SpecialCharsTest are being investigated by @jcarranzan

@fedinskiy
Copy link
Contributor Author

fedinskiy commented Mar 12, 2024

Failure in ArtifactGeneratorTest is due to this issue, quarkusio/quarkus#39330, should be fixed in next 3.8 release

@rsvoboda
Copy link
Member

Let's wait for details about SpecialCharsTest, otherwise this is OK to merge. Failing tests are not ideal, but I don't think it's worth disabling them.

@fedinskiy
Copy link
Contributor Author

@rsvoboda special chars test fails due to quarkusio/quarkus#39368

@jcarranzan
Copy link

jcarranzan commented Mar 12, 2024

Hi, After reviewing the logs in the CI and executing them on localhost, at first, I thought that the SpecialCharsTest could be related to the recent dependency name changes (https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.7#rest-client-gear-white_check_mark). However, after discussing it with @fedinskiy , we concluded that it's not related. We have already opened an issue for this: quarkusio/quarkus#39368

I think it could be related to this change---> https://github.com/quarkusio/quarkus/pull/38406/files but not sure at all.

@rsvoboda rsvoboda merged commit 6acfb1e into quarkus-qe:3.8 Mar 12, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants