-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.8] Use a separate version for IDE config #345
Conversation
c0fea83
to
aae54a6
Compare
Please check the failures and conflict in pom.xml |
Quarkus IDE config is not productised, so it should always use upstream version Also, update version to 3.8.2
See QUARKUS-4028 for details
aae54a6
to
cf10ad3
Compare
Resolved the conflict. |
Failure in ArtifactGeneratorTest is due to this issue, quarkusio/quarkus#39330, should be fixed in next 3.8 release |
Let's wait for details about SpecialCharsTest, otherwise this is OK to merge. Failing tests are not ideal, but I don't think it's worth disabling them. |
@rsvoboda special chars test fails due to quarkusio/quarkus#39368 |
Hi, After reviewing the logs in the CI and executing them on localhost, at first, I thought that the SpecialCharsTest could be related to the recent dependency name changes (https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.7#rest-client-gear-white_check_mark). However, after discussing it with @fedinskiy , we concluded that it's not related. We have already opened an issue for this: quarkusio/quarkus#39368 I think it could be related to this change---> https://github.com/quarkusio/quarkus/pull/38406/files but not sure at all. |
Quarkus IDE config is not productised, so it should always use upstream version
Also, update Quarkus version to 3.8.2
Partially reverts #311