Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include service name in OpenShift deployment template #1039

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Include service name in OpenShift deployment template #1039

merged 1 commit into from
Feb 12, 2024

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Feb 12, 2024 •
edited by michalvavrik

Summary

Without it, tests may fail, when service has name other, than amq. First caught here: quarkus-qe/quarkus-test-suite#1650

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy self-assigned this Feb 12, 2024
@fedinskiy
Copy link
Contributor Author

run tests

michalvavrik
michalvavrik approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

@fedinskiy fedinskiy merged commit e44dde2 into quarkus-qe:main Feb 12, 2024
9 checks passed
@rsvoboda rsvoboda changed the title Include service name in Openshif deployment template Include service name in OpenShift deployment template Feb 12, 2024
@fedinskiy fedinskiy deleted the fix/amqp-template branch February 13, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees

@fedinskiy fedinskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fedinskiy @michalvavrik