Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and test Kafka authentication with SASL_SSL protocols #1065

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

gtroitsk
Copy link
Member

Summary

Add test support for Kafka authentication with SASL_SSL protocols
Tests kafka.security.protocol=SASL_SSL property

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk changed the title Add support for Kafka sasl with ssl Support and test Kafka authentication with SASL_SSL protocols Mar 16, 2024
@gtroitsk gtroitsk marked this pull request as ready for review March 17, 2024 18:37
@gtroitsk
Copy link
Member Author

We need to fix failures in FW using snapshot, because it fails after a minute run. It can be caused by bulk dependencies renaming in Quarkus

@jcarranzan
Copy link
Contributor

Hi @gtroitsk , I left a couple of comments, but in general LGTM.

@jcarranzan jcarranzan merged commit e7f69fa into quarkus-qe:main Mar 19, 2024
8 checks passed
@gtroitsk gtroitsk deleted the support-kafka-sasl-ssl branch March 20, 2024 12:38
@gtroitsk gtroitsk mentioned this pull request Mar 21, 2024
11 tasks
@michalvavrik michalvavrik added the triage/backport-1.4? Quarkus 3.8 stream label Apr 26, 2024
@mjurc mjurc removed the triage/backport-1.4? Quarkus 3.8 stream label Apr 29, 2024
@mjurc
Copy link
Member

mjurc commented Apr 29, 2024

Removing the backport label as this is already in 1.4.z branch

@mjurc mjurc added the triage/backport-1.4? Quarkus 3.8 stream label Apr 29, 2024
@mjurc
Copy link
Member

mjurc commented Apr 29, 2024

And I am adding the backport label as it turns out that one of the 1.4.2.Beta8 tags actually held 1.4.3.Beta8 release of framework, and I based the 1.4.z branch on that wrongly...

@jedla97 jedla97 removed the triage/backport-1.4? Quarkus 3.8 stream label Jun 5, 2024
@jedla97
Copy link
Member

jedla97 commented Jun 5, 2024

Removing backport label as this was part of #1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants