Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change check of Kubernetes annotation for Keycloak resource binding #1096

Merged

Conversation

gtroitsk
Copy link
Member

Summary

After adding Kubernetes support in #1083, tests that uses KeycloakContainer start to fail on bare metal because of java.lang.NoClassDefFoundError: io/quarkus/test/scenarios/KubernetesScenario.
Ideally we don't want to add quarkus-test-kubernetes dependency in each test module, so the next workaround is provided in this PR

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)
  • This change requires execution against K8s (use run kube tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk
Copy link
Member Author

run kube tests

Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michalvavrik michalvavrik merged commit 4e8e0a5 into quarkus-qe:main Apr 22, 2024
9 checks passed
@gtroitsk gtroitsk deleted the fix/k8s-keycloak-resource-binding branch April 22, 2024 11:45
@michalvavrik michalvavrik mentioned this pull request Apr 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants