Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use fabric8 client after closing it #608

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Do not use fabric8 client after closing it #608

merged 1 commit into from
Oct 27, 2022

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Oct 27, 2022 •
edited

Summary

  • This fixes the exception thrown in OperatorManagedResource looking CRD up after fabric8 client was closed after namespace cleanup.

Supersedes #595

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc mjurc self-assigned this Oct 27, 2022
@mjurc mjurc changed the title Openshift client close Do not use fabric8 client after closing it Oct 27, 2022
@mjurc
Do not use fabric8 client after closing it
aae5f41 
* This fixes the exception thrown in OperatorManagedResource looking CRD up
  after fabric8 client was closed after namespace cleanup.
@mjurc
Copy link
Member Author

mjurc commented Oct 27, 2022

run tests

michalvavrik
michalvavrik approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michalvavrik michalvavrik merged commit 6f6d6b6 into quarkus-qe:main Oct 27, 2022
@michalvavrik
Copy link
Contributor

Native failure is not related.

@mjurc mjurc mentioned this pull request Oct 29, 2022
Merged
10 tasks
mjurc added a commit that referenced this pull request Oct 29, 2022
@mjurc
Release 1.2.0.Beta15
e442766 
* #601
* #603
* #606
* #608
@mjurc mjurc mentioned this pull request Oct 30, 2022
Closed
10 tasks
@pjgg pjgg added triage/backport-1.2? Backport to 1.2 branch may be required and removed triage/backport-1.2? Backport to 1.2 branch may be required labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees

@mjurc mjurc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjurc @michalvavrik @pjgg