Update Maven wrapper and fix Quarkus CLI test failures in daily builds #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsvoboda
reviewed
Mar 27, 2023
.mvn/jvm.config
Outdated
| -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 | ||
| -Dmaven.wagon.http.retryHandler.requestSentEnabled=true | ||
| -Dmaven.wagon.http.retryHandler.count=10 | ||
| -Xmx5g |
There was a problem hiding this comment.
I planned to use same settings as Quarkus does, but it seems like they only needs this to fix transient issues on Azure, so we should be fine. I dropped it.
michalvavrik
force-pushed
the
feature/update-mvnw
branch
from
07e9f7b
to
44903b8
Compare
|
@rsvoboda it looks like it is either getting fixed / reverted in upstream. it seems like a good thing we had this old wrapper as long as it's supported. let's wait little with this, if there is no fix tomorrow, I can disable Quarkus CLI test that is failing. |
|
@rsvoboda looks like we have final decision now - 3.6.2 won't be supported now - quarkusio/quarkus#32081 (comment), so we need to do some upgrade in order to fix CI. This PR would do, let me know if you want something different. |
rsvoboda
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apache Maven and wrapper has been recently updated in upstream - quarkusio/quarkus#31836, our CI is creating Quarkus CLI from JARs created by this wrapper and when we run
./quarkus-dev-cli build, it is using our wrapper from Quarkus Test Suite root directory which is old one and incompatible with the one that was used for bulding CLI jar. I opened discussion here quarkusio/quarkus#32081 (comment) to confirm it is expected behavior (and documented). All files I added are copy & paste from Quarkus main project.Please select the relevant options.
run testsphrase in comment)Checklist: