Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDBC transaction recovery for JVM and native scenarios #1356

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

michalvavrik
Copy link
Contributor

Summary

Adds transaction recovery test coverage for native and JVM. OpenShift will require changes in Test Framework that I didn't really explore yet. IMHO there is plenty of changes already and we should wait for OCP. DEV mode is something that is worth to do (especially due to quarkusio/quarkus#34576 (comment)), but not part of original test plan here https://github.com/quarkus-qe/quarkus-test-plans/blob/main/QUARKUS-2739.md and I didn't get to it yet.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Contributor Author

@rsvoboda I am working on OpenShift, MsSQL adjustments suggested by Zheng and considering DEV mode (no effort yet). It call can be done in a separate PR as this one is already big. Thanks

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's quite complex topic and I would need quite some time to get more detailed knowledge. I didn't spot anything that would be suspicious to me.

Just some notes to the topic: as this needs quite some coding, it's necessary to think about the recovery upfront and not in retrospective. Another aspect is that recovery can't be handled by "ops", needs active involvement of the developer (if things go south).

@rsvoboda rsvoboda added the triage/backport-3.2 RHBQ Ghost LTS release label Aug 14, 2023
@rsvoboda rsvoboda merged commit 3aefa5e into quarkus-qe:main Aug 14, 2023
7 checks passed
@michalvavrik michalvavrik deleted the feature/narayana branch August 14, 2023 14:50
@fedinskiy fedinskiy mentioned this pull request Aug 25, 2023
9 tasks
@fedinskiy fedinskiy removed the triage/backport-3.2 RHBQ Ghost LTS release label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants