Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Vert.x web validation module #1516

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

jcarranzan
Copy link
Contributor

Summary

This module covers the functionality of Vert.x web validation (https://vertx.io/docs/vertx-web-validation/java/), basically provides an API to build a handler that performs parsing and validation of the requests.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan marked this pull request as draft November 13, 2023 08:46
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
http/vertx-web-validation/pom.xml Outdated Show resolved Hide resolved
http/vertx-web-validation/pom.xml Outdated Show resolved Hide resolved
@jcarranzan jcarranzan force-pushed the vertx-web-validation branch 2 times, most recently from 64d6ad8 to 2861266 Compare November 14, 2023 11:06
README.md Outdated Show resolved Hide resolved
@jcarranzan jcarranzan marked this pull request as ready for review November 14, 2023 15:23
@jcarranzan jcarranzan changed the title Draft:Vertx web validation Implement Vert.x web validation module Nov 14, 2023
@jcarranzan
Copy link
Contributor Author

It seems CI fails now because opentracing jar is missing: https://repo.maven.apache.org/maven2/io/quarkiverse/opentracing/quarkus-smallrye-opentracing/1.0.0/quarkus-smallrye-opentracing-1.0.0.pomOpentracing and also according to this: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6
have been retired so all CI will fail ( Monitoring: MicroProfile + OpenTracing) and also the modules that use JAEGER.
@michalvavrik Is there any way to run CI excluding Jaeger and Opentracing dependencies?

@michalvavrik
Copy link
Contributor

It seems CI fails now because opentracing jar is missing: https://repo.maven.apache.org/maven2/io/quarkiverse/opentracing/quarkus-smallrye-opentracing/1.0.0/quarkus-smallrye-opentracing-1.0.0.pomOpentracing and also according to this: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6 have been retired so all CI will fail ( Monitoring: MicroProfile + OpenTracing) and also the modules that use JAEGER. @michalvavrik Is there any way to run CI excluding Jaeger and Opentracing dependencies?

It's consequence of quarkusio/quarkus#36602 and it needs to be fixed. I'll do it in a moment.

@jcarranzan
Copy link
Contributor Author

It seems CI fails now because opentracing jar is missing: https://repo.maven.apache.org/maven2/io/quarkiverse/opentracing/quarkus-smallrye-opentracing/1.0.0/quarkus-smallrye-opentracing-1.0.0.pomOpentracing and also according to this: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6 have been retired so all CI will fail ( Monitoring: MicroProfile + OpenTracing) and also the modules that use JAEGER. @michalvavrik Is there any way to run CI excluding Jaeger and Opentracing dependencies?

It's consequence of quarkusio/quarkus#36602 and it needs to be fixed. I'll do it in a moment.

Ok, currently after our PR merged(#1519 and #1520) into main all the CI passed successfully.

@michalvavrik
Copy link
Contributor

run tests

Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one last thing - please squash your commits

@jcarranzan
Copy link
Contributor Author

looks good, one last thing - please squash your commits

done :)

Copy link
Contributor

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job.

@michalvavrik michalvavrik merged commit 49c4a46 into quarkus-qe:main Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants