Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST resource extending abstract class fail on POST/PUT scenario #253

Merged
merged 1 commit into from Sep 10, 2021
Merged

REST resource extending abstract class fail on POST/PUT scenario #253

merged 1 commit into from Sep 10, 2021

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Sep 9, 2021

Reproducer for the issue: quarkusio/quarkus#20008

@pjgg pjgg requested a review from Sgitario September 9, 2021 14:41
Sgitario
Sgitario reviewed Sep 10, 2021
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are ok for me.
But I've a concern (see my only comment) that I would like the oppinion from @mjurc and/or @rsvoboda

security/keycloak-authz/pom.xml Outdated Show resolved Hide resolved
@Sgitario Sgitario requested a review from mjurc September 10, 2021 05:00
rsvoboda
rsvoboda requested changes Sep 10, 2021
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conclusion from chat discussion is to use duplicated approach, please update the PR to have security/keycloak-authz-classic ++ security/keycloak-authz-reactive

@pjgg pjgg force-pushed the feat/authZendpoints branch 3 times, most recently from fa75513 to 1f57467 Compare September 10, 2021 10:33
Sgitario
Sgitario suggested changes Sep 10, 2021
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
security/keycloak-authz-reactive-resteasy/pom.xml Outdated Show resolved Hide resolved
@pjgg pjgg force-pushed the feat/authZendpoints branch 3 times, most recently from bbf5146 to e8c9e6c Compare September 10, 2021 10:41
REST resource extending abstract class fail on POST/PUT scenario
0164d3b 
Add new scenario in order to cover reactive cases
Rename security/keycloak-authz module to security/keycloak-authz-classic
@pjgg pjgg requested a review from Sgitario September 10, 2021 10:42
@Sgitario
Copy link
Contributor

run tests

@Sgitario Sgitario merged commit 35e2ac7 into quarkus-qe:main Sep 10, 2021
@pjgg pjgg mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

@mjurc mjurc Awaiting requested review from mjurc

@rsvoboda rsvoboda Awaiting requested review from rsvoboda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjgg @Sgitario @rsvoboda