Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java version picker #595

Closed
ia3andy opened this issue Oct 11, 2021 · 12 comments
Closed

Add Java version picker #595

ia3andy opened this issue Oct 11, 2021 · 12 comments

Comments

@ia3andy
Copy link
Collaborator

ia3andy commented Oct 11, 2021

Description
I believe it would be a good addition

@maxandersen
Copy link
Collaborator

What would it do?

@ia3andy
Copy link
Collaborator Author

ia3andy commented Oct 12, 2021

Select between different java version, it would just change the pom.xml/... target version.

@maxandersen
Copy link
Collaborator

So 11 or 17 ?

I'm not sure it's worth adding another ui element to already busy form.

it also will beg the question to the user wether quarkus behaves differently / has different capabilities dependent on the java version.

So far it does not thus is it worth it ?

I would keep it at 11 and maybe mention it works with 17 too.

Wdyt?

@rkraneis
Copy link

As long as Mandrel does not support Java 17, I would not enable this as a selectable option, as it complicates native compilation. Those users who then figure out how to build with GraalVM instead of Mandrel will also be able to figure out how to change the Java version ... (using Quarkus native on 17 myself).

@maxandersen
Copy link
Collaborator

We can always mark it as experimental so I would not let mandrelissues be a blocker for this one.

But I also don't think we should add this as code quarkus feature - it needs to be part of quarkus devtools which would take care of maven/Gradle/dockerfile differences.

@JurrianFahner
Copy link

Not everyone generates quarkus projects on the website directly. Today I created from Intellij directly (it uses the code.quarkus.io site to create the forms in intellij).

I was surprised to learn that it was on java 11, because I expected java 17 (this LTS java version is GA since september already).

In my case I would like to use the JEP359 (record classes).

To have a choice as a quarkus with the warning that I make an experimental choice seems for me a perfect solution. It's up to the user whether experimental is acceptable.

@ia3andy
Copy link
Collaborator Author

ia3andy commented Nov 23, 2021

We have an ongoing effort for this:
quarkusio/quarkus#20849

As soon as it's available, we will add the java version picker (11, 17) on code.quarkus.io (and its API)

@ia3andy
Copy link
Collaborator Author

ia3andy commented Nov 23, 2021

But I also don't think we should add this as code quarkus feature - it needs to be part of quarkus devtools which would take care of maven/Gradle/dockerfile differences.

On the other command line tools, it uses the current java version. From code.quarkus.io and IDEs we need a picker for this obviously.

@ia3andy
Copy link
Collaborator Author

ia3andy commented Nov 23, 2021

I added a feature request for this to also be a parameter in the command line tooling quarkusio/quarkus#21629

@maxandersen
Copy link
Collaborator

As soon as it's available, we will add the java version picker (8, 11, 17) on code.quarkus.io (and its API)

Quarkus 2 does not support Java 8 this I assume you mean just 11 and 17 :)

@ia3andy
Copy link
Collaborator Author

ia3andy commented Nov 23, 2021

I didn't know we dropped support for it, maybe we should disable it in the generator then..

@ia3andy
Copy link
Collaborator Author

ia3andy commented Mar 30, 2022

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants