-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a parameter to select the java version for generated Quarkus projects (CLI and Maven) #21629
Comments
/cc @ebullient, @maxandersen, @quarkusio/devtools |
where is that done ? That means if you run on on java 8,9,10,12,13,14,15, 16 or 17 what happens? I think its a bad default to use the shell java version. It should be a fixed default (i.e. Java 11 until Java 17 is mainstream) to work reliably. |
|
i want to contribute to this issue please help me? |
First question is the name?
(I do prefer 1.) Maven Plugin: CLI CreateApp (need to decide with @ebullient where to add the parameter) : Method to set java target (if we decide to use |
cli already has flags for --java, maybe have version as a optional value for it ? --java=11 ? That does though cause a bit of mess since you can't then specify java version when using --kotlin as it currently excludes use of --java. I'm wondering if we shouldn't make target language be implicitly java so you don't need --java to set target language to java? Then you can do So --java simply is used to set targeted java version? |
I could drop java from the exclusive language group, and use it as a java version setting flag instead... unless we should be adding a --jvm option for setting the version (even when used with kotlin or scala) |
Description
Continuing on #20849
The current implementation (👆) uses the shell java version to determine a compatible version (11 or 17 for now) in generated project.
We need to add this as a parameter (11 or 17, default still being automatic based on shell java version) in the CLI and Maven plugin.
Implementation ideas
See comment #21629 (comment)
The text was updated successfully, but these errors were encountered: