Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2i native image builder doesn't respect a project's gradle wrapper nor any overridden project settings #59

Open
edeandrea opened this issue Mar 11, 2020 · 0 comments

Comments

@edeandrea
Copy link

The assemble script in the quarkus-native-binary-s2i-scripts module don't respect a project's Gradle wrapper

if "$USE_GRADLE"; then
  BUILD_DIR=build
  mkdir -p build/libs
  gradle buildNative --docker-build=false

This script always assumes that a build's output directory is build and uses the gradle script instead of the gradlew script. By not using gradlew, the image forces the build to a particular Gradle version instead of using the version that the project itself is declaring should be used. In addition a particular build may have changed the $buildDir property, in which case the build directory won't exist and output will be elsewhere.

@edeandrea edeandrea changed the title s2i images don't respect a project's gradle wrapper nor any overridden project settings s2i native image builder doesn't respect a project's gradle wrapper nor any overridden project settings Mar 11, 2020
matthyx pushed a commit to matthyx/quarkus-images that referenced this issue Sep 20, 2021
…displaces-passthrough

Bug 1691190: hostindex: Path-based TLS displaces passthrough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant