Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to open quickstarts in che.openshift.io #281

Open
1 of 4 tasks
maxandersen opened this issue Sep 13, 2019 · 5 comments
Open
1 of 4 tasks

Add links to open quickstarts in che.openshift.io #281

maxandersen opened this issue Sep 13, 2019 · 5 comments

Comments

@maxandersen
Copy link
Contributor

maxandersen commented Sep 13, 2019

che 7 has a new notion of devfile.yml which we in theory should be able to add to the quickstarts to give links to che.openshift.io that setup a environment to edit/run most getting started projects.

This issue is to discuss this with Che team and try find what is possible and what we might need to avoid doing too much manual work.

For now biggest issues I've found:

  • devfile must be in root which is counter to layout common to quickstarts where there are multiple projects and you don't want all opened/imported.
  • devfile have a lot of absolute references to git repos making it impossible to do your own git clone and use them as your own reference
  • tasks/commands have absolute references to how mvn command are run rather than looking up contextually to where you are (i.e. instead of '/project/quickstarts/getting-started' I would like to have a way to say 'nearest parent from current editor/context that has a pom.xml'
  • how does one point to a branch with devfile.yml in it ? (using 'tree/' works: che.openshift.io/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che - but git refs inside it are still absolute)
@maxandersen
Copy link
Contributor Author

to begin with we could start with explicit devfile.yml for the getting-started example.

@maxandersen
Copy link
Contributor Author

so che.openshift.io/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che works and checks out the project as expected as long as there is no devfile.yaml.

If I put a devfile.yaml in there it stops checking out the project and seem to force me to have an absolute reference like:

projects:
  -
    name: console-java-simple
    source:
      type: git
      location: "https://github.com/che-samples/console-java-simple.git"projects:
  -
    name: console-java-simple
    source:
      type: git
      location: "https://github.com/maxandersen/quarkus-quickstarts.git"

That is counter intuitive and not very flexible.

@gazarenkov
Copy link

+1 , this behavior does not look really clear.
It looks better to use 2 different parameter names for link to devfile containing directory (repository) and to the project itself.
Could you create a corresponding issue in a Che repo for better visibility?

@maxandersen
Copy link
Contributor Author

maxandersen commented Sep 15, 2019

Could you create a corresponding issue in a Che repo for better visibility?

Yes, I opened a good bunch of issues found for this issue.

eclipse-che/che#14547 is the one for more saner location/github info rest is a mix of other things:

eclipse-che/che#14546
eclipse-che/che#14548
eclipse-che/che#14549
eclipse-che/che#14550

@sunix
Copy link

sunix commented Sep 16, 2019

linking to this one: eclipse-che/che#14506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants