-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow .devfile.yaml
#14548
Comments
@ibuziuk i tried have a quick look and I can't find where che searches for devfile...can you give a pointer ? |
does not look like .withDevfileFilename() allows setting multiple possible locations. But if we add a fallback at https://github.com/eclipse/che/blob/8c2be9a8f4aa16377d430e141bd30ca62aad4ede/wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilder.java#L117 |
if @l0rd don't mind I think we can take this task to the next sprint. We need to agree on the order of the search. Is this correct order correct, any addition?
|
Yes let's take this for next sprint, I think we owe it to @maxandersen |
Let this dot be known as the maxandersen dot from this day forth. :) |
What if both I don't think that it is a bad thing to have a devfile file always visible. |
@kadel at least we give the choice to the project team which files it wish to work with |
How about at least showing a warning when there are both @maxandersen Why it is a problem when devfile.yaml shows up in the file explorer? |
Isn't this something you could technically just use a setting for?
and the devfile won't appear in the project explorer |
some projects maybe opened by different IDEs ... and I guess we don't want to pollute a project view with all the files for Jenkins, Che, VSCode, travis, .github, etc .... what ever the IDE you are using, it is a user preference to hide these files or not |
What about Windows? Are the dotfiles hidden there also by default? |
every time I generated project templates over the last 15 years there are an uproar when these files are included by default. They only are accepted if they are universally used across the development team - i.e. Dockerfile are a recent addition which been accepted as okey - but devfile will at least initially be used by a mere fraction of users of our standard projects thus adding it front and center will make people complain. I'll keep it simple - if you want quarkus and other middleware runtimes to include support for devfile for che and odo by default it needs to be possible to hide it by default. |
that means we or the user need to include such config out of the box of every IDE (adding even more files) and it will still be visible by default by default in a shell. |
yes they are. you don't see .git, .gitignore, .dockerignore, .vscode, .intellij, .eclipse neither. |
If we allow this then tools need to error out when both problem scenario
|
Current PR uses list of devfile names that is sorted by priority, so if multiple devfiles are found, we take the one nearest to the top. I've just blocked the PR, because based on discussions here, redhat-developer/odo#3126 and devfile/api#61, we need to reconsider that. |
@sparkoo I do not think we should error. So if we discover both |
We did that list of names configurable. So Che admin can add any amount of names he wants. But yes, in that case we need to check them all for presence. That's sounds logical, but may consume some workspace startup time. At the same time, dashboard indicates which file it picks for creating factory, so an attentive user should not fall into the trap. |
Good point with the dashboard and the startup time. I think we can start with this on Che. I am not even sure if we even need the configuration. |
After some investigation, i found that we cannot show warning on factory accepting stage (at least without serious factory and dashb refactoring) :( |
devfile.yaml
is not really something you want to have listed in your project explorer or listed in directory constantly.Would be great if che would look for
.devfile.yaml
ifdevfile.yaml
is not found.The text was updated successfully, but these errors were encountered: