Brackets used in RETURNING keyword can cause issues

[pjverity]

quarkus-quickstarts/getting-started-reactive-crud/src/main/java/org/acme/reactive/crud/Fruit.java

Line 60 in 375d533

return client.preparedQuery("INSERT INTO fruits (name) VALUES ($1) RETURNING (id)", Tuple.of(name))

The PostgreSQL documentation for use of the RETURNING clause does not indicate that brackets should surround column names in the clause. This only appears to work Ok when returning a single value as in this example. When RETURNING multiple columns it causes all values to be returned as a single bracketed string.

For example, RETURNING (id, name) would return a single column named row with the string value "(1, Kiwi)", causing row.getLong("id") or row.getString("name") to return null.

I would suggest removing the brackets at per PostgreSQL documentation to avoid developers making the mistake of bracketing multiple return values and falling in to this trap.

The Getting Started guide should also be updated if this change is made.

[nderwin]

@gsmet This one can be closed now since the PRs are merged. Maybe I didn't link them correctly so that it was automatically closed.

[gsmet]

Closing, thanks!