Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apache-tika quickstart #316

Merged
merged 1 commit into from Oct 15, 2019
Merged

Add apache-tika quickstart #316

merged 1 commit into from Oct 15, 2019

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Oct 11, 2019

This PR depends on quarkusio/quarkus#4360 because it uses a new odf (OpenDocumentFormat) abbreviation

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you drop the using- prefix from the repository? I'm trying to avoid that from now on.

And the documentation for the main PR should also be updated with this change if it points to this quickstart.

</dependencies>

<build>
<plugins>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is broken here. If you can reindent the file with 4 spaces, it's better.

@sberyozkin sberyozkin changed the title Add using-apache-tika quickstart Add apache-tika quickstart Oct 15, 2019
@sberyozkin
Copy link
Member Author

@gsmet Renamed and fixed the formatting; but not sure how to change the commit message as the r instruction did not work.

@gsmet gsmet merged commit 6a10056 into quarkusio:development Oct 15, 2019
@gsmet
Copy link
Member

gsmet commented Oct 15, 2019

@sberyozkin for the last commit, you can just use git commit --amend. That's what I did before merging.

Thanks!

@sberyozkin
Copy link
Member Author

@gsmet, thanks, did not realize I could follow up with this command after a rebase :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants