Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove native build profile for Google Cloud Functions #645

Merged
merged 1 commit into from Sep 8, 2020
Merged

Remove native build profile for Google Cloud Functions #645

merged 1 commit into from Sep 8, 2020

Conversation

loicmathieu
Copy link
Contributor

@loicmathieu loicmathieu commented Aug 27, 2020 •
edited

Remove the native profile for Google Cloud Functions quickstarts as it was done for the integration tests.

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has native tests (mvn clean verify -Pnative)
  • makes sure the documentation must not be updated
  • links the documentation update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • For new quickstart, is located in the directory component-quickstart
  • For new quickstart, is added to the root pom.xml and README.md

@loicmathieu loicmathieu marked this pull request as ready for review August 27, 2020 13:21
@gsmet gsmet merged commit 5ba1c03 into quarkusio:development Sep 8, 2020
@gsmet
Copy link
Member

gsmet commented Sep 8, 2020

Thanks!

@loicmathieu loicmathieu deleted the google-cloud-functions-native-build branch September 23, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loicmathieu @gsmet