Missing spaces in the super powers

[cescoffier]

The imports.sql had an import issue. The superpowers are missing some spaces.
For example: WillInvisibilityLongevityMaster. It should be "Will Invisibility Longevity Master"

[edeandrea]

That's what was on the most recent export I got from

https://raw.githubusercontent.com/cescoffier/supes-data/master/heroes-import.sql

https://raw.githubusercontent.com/cescoffier/supes-data/master/villains-import.sql

[cescoffier]

Yeah, I would need to regenerate these files too.

[edeandrea]

I notice there are some json files as well in that repo you have. Do those json files contain all the same records? It looks like it uses an array of strings and the powers have spaces in them.

If so, I bet I could write a quick script which re-generates the sql files from that.

[edeandrea]

Maybe this is also a good opportunity to separate the persistence model from the view model and use Mapstruct in between?

Maybe the persistence model stores the powers as a List<String> and the view model just uses String?

[edeandrea]

@cescoffier How's this?

https://raw.githubusercontent.com/quarkusio/quarkus-super-heroes/characterdata/all-heroes.sql

https://raw.githubusercontent.com/quarkusio/quarkus-super-heroes/characterdata/all-villains.sql

I pulled in the json files in your repo into the characterdata branch and then I created a script which generates the SQL files from the json files: https://raw.githubusercontent.com/quarkusio/quarkus-super-heroes/characterdata/generate-sql-from-json.groovy (things like this are VERY trivial in Groovy!)

It can be run like groovy generate-sql-from-json.groovy all-heroes.json all-heroes.sql hero (for Heroes) and groovy generate-sql-from-json.groovy all-villains.json all-villains.sql villain (for Villains).

If this looks good to you I'll move it into the main branch and re-run my script which randomly grabs 100 of each

[cescoffier]

Looks great! What about using JBang instead of Groovy? It will make @maxandersen happy.

[edeandrea]

Java is so over-complicated when it comes to things like this :) You see how simple it is in Groovy since dealing with structured data is part of the language itself.