Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain4j integration #496

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

edeandrea
Copy link
Collaborator

@edeandrea edeandrea commented Dec 13, 2023

Switch the narration app to use the quarkus-langchain4j extension instead of Microsoft Semantic Kernel.

Fixes #421
Fixes #368

@edeandrea edeandrea force-pushed the langchain4j-integration branch 5 times, most recently from c21573c to b2a9fe1 Compare December 14, 2023 17:05
@edeandrea
Copy link
Collaborator Author

Need to wait for quarkiverse/quarkus-langchain4j#149 and quarkiverse/quarkus-langchain4j#148 to be incorporated into a release before merging this.

@edeandrea edeandrea force-pushed the langchain4j-integration branch 5 times, most recently from 4901f2f to 11da466 Compare December 15, 2023 17:10
@edeandrea edeandrea marked this pull request as ready for review December 18, 2023 15:22
@edeandrea
Copy link
Collaborator Author

Waiting for quarkiverse/quarkus-langchain4j#149 and quarkiverse/quarkus-langchain4j#145 to be released and incorporated into this before merging.

@edeandrea
Copy link
Collaborator Author

@geoand Would you mind taking a look? You can focus on changes just in the rest-narration app.

@edeandrea edeandrea force-pushed the langchain4j-integration branch 3 times, most recently from 8c865c9 to 182c4f6 Compare December 20, 2023 16:55
Signed-off-by: Eric Deandrea <edeandrea@redhat.com>
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edeandrea edeandrea merged commit 31a0992 into quarkusio:main Dec 20, 2023
15 checks passed
@edeandrea edeandrea deleted the langchain4j-integration branch December 20, 2023 18:19
edeandrea added a commit to edeandrea/quarkus-super-heroes that referenced this pull request Jan 4, 2024
Signed-off-by: Eric Deandrea <edeandrea@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch narration app to use quarkus-langchain4j Support native compilation in narration service
2 participants