Add a parent pom for IDEs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeandrea
reviewed
Feb 1, 2022
|
I'll also have to check whether or not this breaks the automation |
|
Looks good. Thanks for the PR! |
|
We could include a reference to the parent pom in each child, but that couples the code a little bit. This way we "simulate" that all the projects are totally independent. I think it's better, it kind of says "you see, each microservice is totally independent from the others" ;o) |
|
I like it and agree I didn't want to couple the projects together. I tested it locally before merging so I think we're good. CI is running now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7