Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding profile-based configuration for local deployments #93

Merged
merged 1 commit into from Jun 17, 2022

Conversation

edeandrea
Copy link
Collaborator

Adding multiple profiles to each app to pre-configure deployment options if wanting to push/deploy directly from a developer machine to kubernetes.

@edeandrea edeandrea marked this pull request as ready for review May 31, 2022 17:57
@edeandrea edeandrea requested a review from tqvarnst May 31, 2022 17:57
@edeandrea
Copy link
Collaborator Author

edeandrea commented May 31, 2022

Hey @tqvarnst Would you like to take a look at this? Its based on a conversation we had a while ago re: adding separate profiles for when pushing directly to k8s from a local machine.

I implemented several combinations/permutations of profiles:

  • knative
  • knative-17
  • knative-openshift
  • knative-openshift-17
  • kubernetes
  • kubernetes-17
  • minikube
  • minikube-17
  • openshift
  • openshift-17

I also updated all the READMEs.

Let me know what you think.

One thing I noticed is that it doesn't seem to let me build a profile hierarchy. I've asked Roberto Cortez about it.

@edeandrea
Copy link
Collaborator Author

I confirmed with @radcortez that building a profile hierarchy isn't something you can do right now. I created smallrye/smallrye-config#767 for it.

Copy link

@tqvarnst tqvarnst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edeandrea edeandrea merged commit 6662747 into quarkusio:main Jun 17, 2022
@edeandrea edeandrea deleted the k8s-profiles branch June 17, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants