Trying to add custom java rule

[JiriOndrusek]

This is an experiment with addition of java custom rule among the upgrade process.

Current PR is buildable but when upgrade is executed, I'm getting:

[INFO] [INFO] Using active recipe(s) [io.quarkus.openrewrite.Quarkus]
[INFO] [INFO] Using active styles(s) []
[INFO] [INFO] Validating active recipes...
[INFO] [ERROR] Recipe validation error in custom.recipeList[0] (in file:/tmp/quarkus-project-recipe-10422657056364188551.yaml): recipe 'org.apache.camel.quarkus.poc.SayHelloRecipe' does not exist.
[INFO] [ERROR] Recipe validation error in custom.recipeList[0] (in file:/tmp/quarkus-project-recipe-10422657056364188551.yaml): recipe 'org.apache.camel.quarkus.poc.SayHelloRecipe' does not exist.
[INFO] [ERROR] Recipe validation error in custom.recipeList[0] (in file:/tmp/quarkus-project-recipe-10422657056364188551.yaml): recipe 'org.apache.camel.quarkus.poc.SayHelloRecipe' does not exist.

I expect, that the maven-rewrite plugin which is resolved in runtime has to contain a reference to recipe. Something like this xml definition:

   <plugin>
            <groupId>org.openrewrite.maven</groupId>
            <artifactId>rewrite-maven-plugin</artifactId>
            <version>4.46.0</version>
            <configuration>
                <activeRecipes>
                    <recipe>org.apache.camel.quarkus.update.SayHelloRecipe</recipe>
                </activeRecipes>
            </configuration>
            <dependencies>
                <dependency>
                    <groupId>org.apache.camel.quarkus.update</groupId>
                    <artifactId>recipes</artifactId>
                    <version>1.0-SNAPSHOT</version>
                </dependency>
            </dependencies>
        </plugin>

[JiriOndrusek]

@gsmet May I ask you for help?

[JiriOndrusek]

The standalone project with the recipe alone (used in the xml configuration of the plugin) is here (https://github.com/JiriOndrusek/recipes)

[ia3andy]

@JiriOndrusek What is missing in the existing OpenRewrite recipes that makes you want to write your own in Java?

IMO, if we could stick to the yaml definition and when needed discuss with the OpenRewrite team to have missing features integrated, it will be less to maintain by us (and also less integration work).

[gsmet]

That won't fly. Of course, we will favor the YAML ones but we will for sure need custom recipes at some point. I'm working on the infrastructure to support that as we speak.

[gsmet]

@JiriOndrusek I pushed some additional changes to your PR but the big missing piece is in the core: quarkusio/quarkus#33983

[JiriOndrusek]

@gsmet thanks for your changes, I'm going to verify it with my local quarkus build and let you know if quarkusio/quarkus#33983 works as expected.

[maxandersen]

IMO, if we could stick to the yaml definition and when needed discuss with the OpenRewrite team to have missing features integrated, it will be less to maintain by us (and also less integration work).

one of the main points of using openrewrite is that we had the ability to provide custom code (which if made sense could be pushed to openrewrite).