Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smallrye-stork - New service discovery implementation based on Knative #19

Closed
cescoffier opened this issue Nov 10, 2022 · 2 comments · Fixed by quarkusio/quarkus#30272
Closed

Comments

@cescoffier
Copy link
Member

(From smallrye/smallrye-stork#402)
We would need a new service discovery implementation in Stork for KNative. This SD locates the KNative service (and not the pods as we do for Kubernetes). It would not be possible to use load balancing. However, if you use KNative, load balancing can be handled there.

This SD would take a (Knative) service name as parameter and search for it in the current (or configured) namespace. It will not check if there are pods, just locate the service, resolve the name and return that name. It fails if no service can be found. You will never have more than one service (this needs to be verified when using revisions).

See Quarkus #146

upstream-organization: SmallRye
upstream-repository: smallrye-stork
upstream-issue: 402
upstream-status: open
upstream-milestone: unplanned
@cescoffier
Copy link
Member Author

Going to be fixed by quarkusio/quarkus#30272.

@cescoffier
Copy link
Member Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants