Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New service discovery implementation based on Knative #402

Closed
aureamunoz opened this issue Nov 2, 2022 · 1 comment · Fixed by #421
Closed

New service discovery implementation based on Knative #402

aureamunoz opened this issue Nov 2, 2022 · 1 comment · Fixed by #421
Assignees
@aureamunoz
Labels
on-roadmap
Milestone
1.4.1

Comments

@aureamunoz
Copy link
Collaborator

We would need a new service discovery implementation in Stork for KNative. This SD locates the KNative service (and not the pods as we do for Kubernetes). It would not be possible to use load balancing. However, if you use KNative, load balancing can be handled there.

This SD would take a (Knative) service name as parameter and search for it in the current (or configured) namespace. It will not check if there are pods, just locate the service, resolve the name and return that name. It fails if no service can be found. You will never have more than one service (this needs to be verified when using revisions).

See Quarkus #146
@aureamunoz aureamunoz self-assigned this Nov 2, 2022
@edeandrea edeandrea mentioned this issue Nov 9, 2022
Closed
@cescoffier cescoffier mentioned this issue Nov 10, 2022
Closed
@cescoffier
Copy link
Contributor

Followed up by quarkusio/quarkus-upstream-roadmap#19.

organization: QuarkusIO
repository: quarkus-upstream-roadmap
issue: 19
url: https://github.com/quarkusio/quarkus-upstream-roadmap/issues/19

aureamunoz added a commit to aureamunoz/smallrye-stork that referenced this issue Nov 28, 2022
@aureamunoz
feature: implement knative service discovery
95d6049 
Fixes smallrye#402
@aureamunoz aureamunoz mentioned this issue Nov 28, 2022
Merged
aureamunoz added a commit to aureamunoz/smallrye-stork that referenced this issue Dec 12, 2022
@aureamunoz
feature: implement knative service discovery
4155f68 
Fixes smallrye#402
aureamunoz added a commit to aureamunoz/smallrye-stork that referenced this issue Dec 13, 2022
@aureamunoz
feature: implement knative service discovery
10b8797 
Fixes smallrye#402
aureamunoz added a commit to aureamunoz/smallrye-stork that referenced this issue Dec 16, 2022
@aureamunoz
feature: implement knative service discovery
4635ec0 
Fixes smallrye#402
aureamunoz added a commit to aureamunoz/smallrye-stork that referenced this issue Dec 30, 2022
@aureamunoz
feature: implement knative service discovery
98fc8df 
Fixes smallrye#402
aureamunoz added a commit to aureamunoz/smallrye-stork that referenced this issue Jan 9, 2023
@aureamunoz
feature: implement knative service discovery
b6f8545 
Fixes smallrye#402
cescoffier pushed a commit that referenced this issue Jan 9, 2023
@aureamunoz
feature: implement knative service discovery (#421)
5f50ff5 
Implement knative service discovery

Fixes #402

- fix: setup knative service data properly in test
- Fix revapi configuration
- Explain differences between Knative and K8s according to review
@cescoffier cescoffier modified the milestones: 1.4.0, 1.4.1 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aureamunoz aureamunoz

Labels
on-roadmap
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

feature: implement knative service discovery aureamunoz/smallrye-stork
2 participants
@cescoffier @aureamunoz