Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Quarkus 2.13 #183

Closed
agoncal opened this issue Oct 4, 2022 · 6 comments · Fixed by quarkusio/quarkus#28462
Closed

Bump to Quarkus 2.13 #183

agoncal opened this issue Oct 4, 2022 · 6 comments · Fixed by quarkusio/quarkus#28462
Assignees
@agoncal

Comments

@agoncal
Copy link
Collaborator

agoncal commented Oct 4, 2022

No description provided.

@agoncal agoncal self-assigned this Oct 4, 2022
@oliv37
Copy link
Contributor

oliv37 commented Oct 8, 2022 •
edited
Loading

I'm getting the following error when executing the test VillainResourceTest.shouldNotAddInvalidItem() with Quarkus 2.13.1

2022-10-08 15:18:18,874 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (executor-thread-0) HTTP Request to /api/villains failed, error id: 76cb5d1d-ebcf-434f-b7ba-687a6ad797c5-1: java.lang.NullPointerException
        at io.quarkus.hibernate.validator.runtime.jaxrs.ResteasyReactiveViolationExceptionMapper.buildViolationReportResponse(ResteasyReactiveViolationExceptionMapper.java:78)
        at io.quarkus.hibernate.validator.runtime.jaxrs.ResteasyReactiveViolationExceptionMapper.toResponse(ResteasyReactiveViolationExceptionMapper.java:43)
        at io.quarkus.hibernate.validator.runtime.jaxrs.ResteasyReactiveViolationExceptionMapper.toResponse(ResteasyReactiveViolationExceptionMapper.java:24)
        at org.jboss.resteasy.reactive.server.core.RuntimeExceptionMapper.mapException(RuntimeExceptionMapper.java:95)
        at org.jboss.resteasy.reactive.server.core.ResteasyReactiveRequestContext.mapExceptionIfPresent(ResteasyReactiveRequestContext.java:342)
        at org.jboss.resteasy.reactive.server.handlers.ExceptionHandler.handle(ExceptionHandler.java:15)
        at io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeHandler(QuarkusResteasyReactiveRequestContext.java:124)
        at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:142)
        at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:564)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
        at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
        at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)

Adding @Produces(APPLICATION_JSON) to VillainResource.createVillain solves the problem although I don't really understand why.

@cescoffier
Copy link
Member

Hum that looks like a bug. @geoand @gsmet any changes that could explain it?

@geoand
Copy link
Collaborator

geoand commented Oct 8, 2022

Definitely sounds like a bug. Not sure what could have caused it

@gsmet
Copy link
Member

gsmet commented Oct 8, 2022

Given changing the content type fixes the issue, maybe the PR that pushed plain text violation errors for plain text?

@geoand
Copy link
Collaborator

geoand commented Oct 10, 2022

That seems very likely given the stactktrace, let me take a closer look.

@geoand geoand mentioned this issue Oct 10, 2022
Merged
@geoand
Copy link
Collaborator

geoand commented Oct 10, 2022

quarkusio/quarkus#28462 is the fix

gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 10, 2022
@geoand @gsmet
Prevent possible NPE when building violations report
5ae7c82 
The NPE could happen when Response was used as a return type
and no @produces annotation was present.

Fixes: quarkusio/quarkus-workshops#183
(cherry picked from commit 1a15852)
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 16, 2022
@geoand @igorregis
Prevent possible NPE when building violations report
0b7d0b1 
The NPE could happen when Response was used as a return type
and no @produces annotation was present.

Fixes: quarkusio/quarkus-workshops#183
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 16, 2022
@geoand @igorregis
Prevent possible NPE when building violations report
ba46f5b 
The NPE could happen when Response was used as a return type
and no @produces annotation was present.

Fixes: quarkusio/quarkus-workshops#183
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 16, 2022
@geoand @igorregis
Prevent possible NPE when building violations report
1af4061 
The NPE could happen when Response was used as a return type
and no @produces annotation was present.

Fixes: quarkusio/quarkus-workshops#183
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 17, 2022
@geoand @igorregis
Prevent possible NPE when building violations report
9fd25e8 
The NPE could happen when Response was used as a return type
and no @produces annotation was present.

Fixes: quarkusio/quarkus-workshops#183
tmihalac pushed a commit to tmihalac/quarkus that referenced this issue Oct 27, 2022
@geoand @tmihalac
Prevent possible NPE when building violations report
12f6d27 
The NPE could happen when Response was used as a return type
and no @produces annotation was present.

Fixes: quarkusio/quarkus-workshops#183
@agoncal agoncal mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agoncal agoncal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent possible NPE when building violations report geoand/quarkus
5 participants
@cescoffier @agoncal @gsmet @geoand @oliv37