Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transactional observer without jta warning #14981

Closed
Postremus opened this issue Feb 10, 2021 · 0 comments · Fixed by #14968
Closed

Improve transactional observer without jta warning #14981

Postremus opened this issue Feb 10, 2021 · 0 comments · Fixed by #14968
Labels
kind/enhancement New feature or request
Milestone

Comments

@Postremus
Copy link
Member

When an application has a transaction observer, but does not depend on JTA, following warning is printed once on startup:

The observer %s makes use of %s transactional observers but no JTA capabilities were detected.

According to the spec:

If no transaction is in progress when the event is fired, they are notified at the same time as other observers.

This is already the behavior in case of:

  • JTA is present, but no Transaction is running
  • JTA is not present. In this case however, the warning is logged at startup.

This warning was therefore a bit misleading in my opinion, since I first thought that the observer would never be triggered.
In a discussion on zulip, we agreed on expanding the message.

Relevant chat: https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Use.20alternative.20observer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant