Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arc - support ArcInvocationContext as method parameter #15660

Closed
manovotn opened this issue Mar 12, 2021 · 1 comment · Fixed by #16627
Closed

Arc - support ArcInvocationContext as method parameter #15660

manovotn opened this issue Mar 12, 2021 · 1 comment · Fixed by #16627
Assignees
@manovotn
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Milestone
2.0.0.Alpha1

Comments

@manovotn
Copy link
Contributor

Description
Currently, in order to use ArcInvocationContext, you'd need to cast ordinary InvocationContext to ArcInvocationContext inside the method. Instead, we could allow to use ArcInvocationContext directly as a parameter of the interceptor method.

Implementation ideas
Changes will be needed in multiple areas but for starters I know that:

  • We generate interceptor beans that implement javax.enterprise.inject.spi.Interceptor.intercept(InterceptionType, T, InvocationContext)
  • InterceptorInfo#validateSignature() currently allows only InvocationContext as parameter type

Related to #15633
Cc @mkouba
@manovotn manovotn added kind/enhancement New feature or request area/arc Issue related to ARC (dependency injection) labels Mar 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 12, 2021

/cc @mkouba

@manovotn manovotn mentioned this issue Mar 12, 2021
Merged
@manovotn manovotn self-assigned this Apr 19, 2021
@manovotn manovotn mentioned this issue Apr 19, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manovotn manovotn

Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging a pull request may close this issue.

Allow usage of ArcInvocationContext as interceptor method parameter. manovotn/quarkus
1 participant
@manovotn