Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling should display a message saying the extension to add has not been found #16353

Closed
ia3andy opened this issue Apr 8, 2021 · 5 comments · Fixed by #17111
Closed

Tooling should display a message saying the extension to add has not been found #16353

ia3andy opened this issue Apr 8, 2021 · 5 comments · Fixed by #17111
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working triage/duplicate This issue or pull request already exists
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Apr 8, 2021

Describe the bug

Quarkus CLI "qs add not-found" is not showing any output (even when a valid extension is in the list)

~/D/code-with-quarkus> qs add not-found                                                                        
~/D/code-with-quarkus>     
~/D/code-with-quarkus> qs add not-found resteasy-jackson                                                     
~/D/code-with-quarkus> qs add resteasy-jackson                                                                
[SUCCESS] ✅ Extension io.quarkus:quarkus-resteasy-jackson has been installed

Expected behavior

It should tell the user something like "No extension have been found matching 'not-found'"

I guess it should add the other extensions if they are found.

@ia3andy ia3andy added the kind/bug Something isn't working label Apr 8, 2021
@quarkus-bot quarkus-bot bot added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Apr 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 8, 2021

/cc @ebullient, @gsmet, @maxandersen

@ia3andy
Copy link
Contributor Author

ia3andy commented Apr 8, 2021

I think the maven command has a similar problem:

~/D/code-with-quarkus> mvn quarkus:add-extension -Dextensions=not-found       
executing mvnw instead of mvn
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 50710  100 50710    0     0   287k      0 --:--:-- --:--:-- --:--:--  286k
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------< org.acme:code-with-quarkus >---------------------
[INFO] Building code-with-quarkus 1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- quarkus-maven-plugin:1.13.1.Final:add-extension (default-cli) @ code-with-quarkus ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.206 s
[INFO] Finished at: 2021-04-08T11:31:27+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:1.13.1.Final:add-extension (default-cli) on project code-with-quarkus: Unable to update the pom.xml file: Unable to add extensions -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:

@ia3andy ia3andy changed the title Quarkus CLI "qs add not-found" is not showing any output Quarkus CLI and mvn commands "qs add not-found" is not showing any output Apr 8, 2021
@ia3andy ia3andy changed the title Quarkus CLI and mvn commands "qs add not-found" is not showing any output Tooling should display a message saying the extension to add has not been found Apr 8, 2021
@maxandersen
Copy link
Contributor

I believe this is a duplicate of #16044

@maxandersen maxandersen added the triage/duplicate This issue or pull request already exists label Apr 8, 2021
@ia3andy
Copy link
Contributor Author

ia3andy commented Apr 8, 2021

@maxandersen it's close, but the case is a bit different here, so both cases need to be handled and tested.

@maxandersen
Copy link
Contributor

what is the different case ? the issue I see is that when there is an extension not found the cli fails siliently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working triage/duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants