Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths issues in main branch (Quarkus 2) #16356

Closed
phillip-kruger opened this issue Apr 8, 2021 · 3 comments · Fixed by #16366
Closed

Paths issues in main branch (Quarkus 2) #16356

phillip-kruger opened this issue Apr 8, 2021 · 3 comments · Fixed by #16366
Labels
kind/bug Something isn't working

Comments

@phillip-kruger
Copy link
Member

Describe the bug

I am testing the main branch (Quarkus 2) and found some issues with paths.

  1. In dev mode, the 404 - Resource Not Found page (go to a page that does not exist) shows some wrong paths

Example the swagger-ui and health-ui now have a * in the path

404

  1. If you click on /q/dev in this page you get:

image

However, add a /, so /q/dev/ renders the page:

image

Note that the URLs for swagger-ui and health-ui on this page is also wrong (containing the *)

Expected behavior

(Describe the expected behavior clearly and concisely.)

Paths should work like before.

Actual behavior

(Describe the actual behavior clearly and concisely.)

Paths is wrong

To Reproduce

Steps to reproduce the behavior:

  1. Create a quarkus app using code.quarkus.io and include openapi and health
  2. Change to use SNAPSHOT-999
  3. Run in dev mode

Configuration

Using default config

Environment (please complete the following information):

Output of uname -a or ver

Linux pkruger 5.11.10-200.fc33.x86_64 #1 SMP Thu Mar 25 16:51:31 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "11" 2018-09-25
OpenJDK Runtime Environment 18.9 (build 11+28)
OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)

GraalVM version (if different from Java)

n/a

Quarkus version or git rev

999-SNAPSHOT

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /opt/maven/apache-maven-3.6.3
Java version: 11, vendor: Oracle Corporation, runtime: /opt/JDK/jdk-11
Default locale: en_ZA, platform encoding: UTF-8
OS name: "linux", version: "5.11.10-200.fc33.x86_64", arch: "amd64", family: "unix"

Additional context

(Add any other context about the problem here.)

/cc @kenfinnigan @ebullient

@phillip-kruger phillip-kruger added the kind/bug Something isn't working label Apr 8, 2021
@phillip-kruger
Copy link
Member Author

Some more info.

version 1.13.1.Final works fine, and there it seems like /q/dev forward/redirect to /q/dev/

@ebullient
Copy link
Contributor

ebullient commented Apr 8, 2021

Resolved by #16366
@phillip-kruger was going to have another look between 2.x branch and 1.13.1 to make sure other changes weren't missed.

@phillip-kruger
Copy link
Member Author

I'll still do that in the morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants